Expose interpolation method to users #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-kev
force-pushed
the
kp/more-interpolate
branch
6 times, most recently
from
ea99bcc to
d627b0d
Compare
ph-kev
changed the title
imreddyTeja
reviewed
Jul 18, 2025
NEWS.md
Outdated
Comment on lines
10
to
11
| `interpolation_method` for choosing which kind of interpolation to do. The | ||
| default is `Interpolations.Linear()`. |
There was a problem hiding this comment.
I think this should be something more along the lines of:
Suggested change
| `interpolation_method` for choosing which kind of interpolation to do. The | |
| default is `Interpolations.Linear()`. | |
| `interpolation_method` for choosing the mode of the gridded interpolation. The | |
| default is `Interpolations.Linear()`. |
I think it should be clear that this sets the mode of the gridded interpolation.
ext/InterpolationsRegridderExt.jl
Outdated
| @@ -21,6 +22,9 @@ struct InterpolationsRegridder{ | |||
| """ClimaCore.Field of physical coordinates over which the data will be interpolated""" | |||
| coordinates::FIELD | |||
|
|
|||
| """Method of interpolation as accepted by Interpolations.jl""" | |||
There was a problem hiding this comment.
I think this should somehow specify this is passed into gridded
ph-kev
force-pushed
the
kp/more-interpolate
branch
from
d627b0d to
8b2fe9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the interpolation method to the users, so that they can change from
Intp.Linear()toIntp.Constant()for example.TODO